From: Phil Sutter Date: Thu, 23 Aug 2018 15:43:22 +0000 (+0200) Subject: ebtables: trivial: Leverage C99-style initializers a bit more X-Git-Tag: v1.8.1~63 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2c4e4d2a7432d483ac5599a15b36d1dc1edf72df;p=thirdparty%2Fiptables.git ebtables: trivial: Leverage C99-style initializers a bit more This nit was discovered when comparing do_commandeb() with do_commandeb_xlate(): Since 'cs' is initialized upon declaration already, initialization of field '.eb.bitmask' may be moved there as well. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- diff --git a/iptables/xtables-eb.c b/iptables/xtables-eb.c index 534714de..68f12500 100644 --- a/iptables/xtables-eb.c +++ b/iptables/xtables-eb.c @@ -769,6 +769,7 @@ int do_commandeb(struct nft_handle *h, int argc, char *argv[], char **table, struct xtables_match *m; struct iptables_command_state cs = { .argv = argv, + .eb.bitmask = EBT_NOPROTO, }; char command = 'h'; const char *chain = NULL; @@ -790,7 +791,6 @@ int do_commandeb(struct nft_handle *h, int argc, char *argv[], char **table, /* prevent getopt to spoil our error reporting */ optind = 0; opterr = false; - cs.eb.bitmask = EBT_NOPROTO; /* Getopt saves the day */ while ((c = getopt_long(argc, argv,