From: NeilBrown <neilb@suse.de>
Date: Thu, 20 Jan 2011 21:59:00 +0000 (+1100)
Subject: error check reading of 'degraded' from sysfs.
X-Git-Tag: mdadm-3.2~65
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2c6ac128c4e9057c9afcdf4097b92488466e52fc;hp=ddee071d3e19c4127bb2b4cd24ef79438e84e054;p=thirdparty%2Fmdadm.git

error check reading of 'degraded' from sysfs.

I'm seen mdadm spinning while failing to read 'degraded'.
This doesn't really fix it, but is a reminder that it needs to be
fixed.

Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/Grow.c b/Grow.c
index bf8e8ad3..14701bdc 100644
--- a/Grow.c
+++ b/Grow.c
@@ -2495,7 +2495,8 @@ static int grow_backup(struct mdinfo *sra,
 		odata--;
 
 	/* Check that array hasn't become degraded, else we might backup the wrong data */
-	sysfs_get_ll(sra, NULL, "degraded", &ll);
+	if (sysfs_get_ll(sra, NULL, "degraded", &ll) < 0)
+		return -1; /* FIXME this error is ignored */
 	new_degraded = (int)ll;
 	if (new_degraded != *degraded) {
 		/* check each device to ensure it is still working */