From: Allison Henderson <allison.henderson@oracle.com>
Date: Fri, 15 Oct 2021 20:28:27 +0000 (-0400)
Subject: xfs: Fix default ASSERT in xfs_attr_set_iter
X-Git-Tag: libxfs-5.14-sync_2021-10-16~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2c8cf7d979bf02d3ee034aea37f624ac5d313059;p=thirdparty%2Fxfsprogs-dev.git

xfs: Fix default ASSERT in xfs_attr_set_iter

Source kernel commit: 4a4957c16dc674d1306a3b43d6b07ed93a7b7a14

This ASSERT checks for the state value of RM_SHRINK in the set path
which should never happen.  Change to ASSERT(0);

Suggested-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c
index edc19de6b..cbac76126 100644
--- a/libxfs/xfs_attr.c
+++ b/libxfs/xfs_attr.c
@@ -612,7 +612,7 @@ xfs_attr_set_iter(
 		error = xfs_attr_node_addname_clear_incomplete(dac);
 		break;
 	default:
-		ASSERT(dac->dela_state != XFS_DAS_RM_SHRINK);
+		ASSERT(0);
 		break;
 	}
 out: