From: Thomas Weißschuh Date: Mon, 11 Aug 2025 12:08:04 +0000 (+0200) Subject: bpf: Don't use %pK through printk X-Git-Tag: v6.18-rc1~175^2~110 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2caa6b88e0ba0231fb4ff0ba8e73cedd5fb81fc8;p=thirdparty%2Fkernel%2Fstable.git bpf: Don't use %pK through printk In the past %pK was preferable to %p as it would not leak raw pointer values into the kernel log. Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the regular %p has been improved to avoid this issue. Furthermore, restricted pointers ("%pK") were never meant to be used through printk(). They can still unintentionally leak raw pointers or acquire sleeping locks in atomic contexts. Switch to the regular pointer formatting which is safer and easier to reason about. Signed-off-by: Thomas Weißschuh Signed-off-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/20250811-restricted-pointers-bpf-v1-1-a1d7cc3cb9e7@linutronix.de --- diff --git a/include/linux/filter.h b/include/linux/filter.h index 1e7fd3ee759e0..52fecb7a1fe36 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -1296,7 +1296,7 @@ void bpf_jit_prog_release_other(struct bpf_prog *fp, struct bpf_prog *fp_other); static inline void bpf_jit_dump(unsigned int flen, unsigned int proglen, u32 pass, void *image) { - pr_err("flen=%u proglen=%u pass=%u image=%pK from=%s pid=%d\n", flen, + pr_err("flen=%u proglen=%u pass=%u image=%p from=%s pid=%d\n", flen, proglen, pass, image, current->comm, task_pid_nr(current)); if (image)