From: Parav Pandit <parav@nvidia.com>
Date: Wed, 13 Jan 2021 12:17:00 +0000 (+0200)
Subject: IB/mlx5: Fix error unwinding when set_has_smi_cap fails
X-Git-Tag: v5.11-rc4~13^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2cb091f6293df898b47f4e0f2e54324e2bbaf816;p=thirdparty%2Fkernel%2Flinux.git

IB/mlx5: Fix error unwinding when set_has_smi_cap fails

When set_has_smi_cap() fails, multiport master cleanup is missed. Fix it
by doing the correct error unwinding goto.

Fixes: a989ea01cb10 ("RDMA/mlx5: Move SMI caps logic")
Link: https://lore.kernel.org/r/20210113121703.559778-3-leon@kernel.org
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 3bae9ba0ead85..fbe3b75f866b1 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -3956,7 +3956,7 @@ static int mlx5_ib_stage_init_init(struct mlx5_ib_dev *dev)
 
 	err = set_has_smi_cap(dev);
 	if (err)
-		return err;
+		goto err_mp;
 
 	if (!mlx5_core_mp_enabled(mdev)) {
 		for (i = 1; i <= dev->num_ports; i++) {