From: Luke Okomilo <github@email.okomilo.com>
Date: Thu, 15 Aug 2024 22:31:16 +0000 (+0100)
Subject: 📝 Fix inconsistent response code when item already exists in docs for testing (#11818)
X-Git-Tag: 0.112.2~67
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2cb1333b971ae17b83499bca952a7803cec21b0c;p=thirdparty%2Ffastapi%2Ffastapi.git

📝 Fix inconsistent response code when item already exists in docs for testing (#11818)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
---

diff --git a/docs_src/app_testing/app_b_an/main.py b/docs_src/app_testing/app_b_an/main.py
index c63134fc9b..c66278fdd0 100644
--- a/docs_src/app_testing/app_b_an/main.py
+++ b/docs_src/app_testing/app_b_an/main.py
@@ -34,6 +34,6 @@ async def create_item(item: Item, x_token: Annotated[str, Header()]):
     if x_token != fake_secret_token:
         raise HTTPException(status_code=400, detail="Invalid X-Token header")
     if item.id in fake_db:
-        raise HTTPException(status_code=400, detail="Item already exists")
+        raise HTTPException(status_code=409, detail="Item already exists")
     fake_db[item.id] = item
     return item
diff --git a/docs_src/app_testing/app_b_an/test_main.py b/docs_src/app_testing/app_b_an/test_main.py
index e2eda449d4..4e1c51ecc8 100644
--- a/docs_src/app_testing/app_b_an/test_main.py
+++ b/docs_src/app_testing/app_b_an/test_main.py
@@ -61,5 +61,5 @@ def test_create_existing_item():
             "description": "There goes my stealer",
         },
     )
-    assert response.status_code == 400
+    assert response.status_code == 409
     assert response.json() == {"detail": "Item already exists"}
diff --git a/docs_src/app_testing/app_b_an_py310/main.py b/docs_src/app_testing/app_b_an_py310/main.py
index 48c27a0b88..c5952be0b3 100644
--- a/docs_src/app_testing/app_b_an_py310/main.py
+++ b/docs_src/app_testing/app_b_an_py310/main.py
@@ -33,6 +33,6 @@ async def create_item(item: Item, x_token: Annotated[str, Header()]):
     if x_token != fake_secret_token:
         raise HTTPException(status_code=400, detail="Invalid X-Token header")
     if item.id in fake_db:
-        raise HTTPException(status_code=400, detail="Item already exists")
+        raise HTTPException(status_code=409, detail="Item already exists")
     fake_db[item.id] = item
     return item
diff --git a/docs_src/app_testing/app_b_an_py310/test_main.py b/docs_src/app_testing/app_b_an_py310/test_main.py
index e2eda449d4..4e1c51ecc8 100644
--- a/docs_src/app_testing/app_b_an_py310/test_main.py
+++ b/docs_src/app_testing/app_b_an_py310/test_main.py
@@ -61,5 +61,5 @@ def test_create_existing_item():
             "description": "There goes my stealer",
         },
     )
-    assert response.status_code == 400
+    assert response.status_code == 409
     assert response.json() == {"detail": "Item already exists"}
diff --git a/docs_src/app_testing/app_b_an_py39/main.py b/docs_src/app_testing/app_b_an_py39/main.py
index 935a510b74..142e23a26a 100644
--- a/docs_src/app_testing/app_b_an_py39/main.py
+++ b/docs_src/app_testing/app_b_an_py39/main.py
@@ -33,6 +33,6 @@ async def create_item(item: Item, x_token: Annotated[str, Header()]):
     if x_token != fake_secret_token:
         raise HTTPException(status_code=400, detail="Invalid X-Token header")
     if item.id in fake_db:
-        raise HTTPException(status_code=400, detail="Item already exists")
+        raise HTTPException(status_code=409, detail="Item already exists")
     fake_db[item.id] = item
     return item
diff --git a/docs_src/app_testing/app_b_an_py39/test_main.py b/docs_src/app_testing/app_b_an_py39/test_main.py
index e2eda449d4..4e1c51ecc8 100644
--- a/docs_src/app_testing/app_b_an_py39/test_main.py
+++ b/docs_src/app_testing/app_b_an_py39/test_main.py
@@ -61,5 +61,5 @@ def test_create_existing_item():
             "description": "There goes my stealer",
         },
     )
-    assert response.status_code == 400
+    assert response.status_code == 409
     assert response.json() == {"detail": "Item already exists"}