From: Colin Vidal <colin@isc.org>
Date: Tue, 16 Sep 2025 12:15:07 +0000 (+0200)
Subject: simplify nchildren count in isc_nm_listenudp
X-Git-Tag: v9.21.14~41^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2cbe958df67ea74fb00846bc47662ad22a917324;p=thirdparty%2Fbind9.git

simplify nchildren count in isc_nm_listenudp

Slight simplification of the logic to define .nchildren listening UDP
socket.
---

diff --git a/lib/isc/netmgr/udp.c b/lib/isc/netmgr/udp.c
index ce1f4bb6386..bb3cb67045a 100644
--- a/lib/isc/netmgr/udp.c
+++ b/lib/isc/netmgr/udp.c
@@ -216,17 +216,16 @@ isc_nm_listenudp(uint32_t workers, isc_sockaddr_t *iface, isc_nm_recv_cb_t cb,
 		return ISC_R_SHUTTINGDOWN;
 	}
 
-	if (workers == 0) {
-		workers = isc__netmgr->nloops;
-	}
-	REQUIRE(workers <= isc__netmgr->nloops);
-
 	sock = isc_mempool_get(worker->nmsocket_pool);
 	isc__nmsocket_init(sock, worker, isc_nm_udplistener, iface, NULL);
 
-	sock->nchildren = (workers == ISC_NM_LISTEN_ALL)
-				  ? (uint32_t)isc__netmgr->nloops
-				  : workers;
+	if (workers == ISC_NM_LISTEN_ALL) {
+		sock->nchildren = (uint32_t)isc__netmgr->nloops;
+	} else {
+		sock->nchildren = workers;
+	}
+	REQUIRE(sock->nchildren <= isc__netmgr->nloops);
+
 	sock->children = isc_mem_cget(worker->mctx, sock->nchildren,
 				      sizeof(sock->children[0]));