From: Alan Modra <amodra@gmail.com>
Date: Fri, 13 Dec 2024 03:18:45 +0000 (+1030)
Subject: small coffgen.c tidy
X-Git-Tag: gdb-16-branchpoint~112
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2cd1fe362711bb7221826cb5e1d791bffc04fc51;p=thirdparty%2Fbinutils-gdb.git

small coffgen.c tidy

_bfd_coff_free_cached_info should always call
_bfd_generic_bfd_free_cached_info, even if _bfd_coff_free_symbols
returns an error.  (It won't return an error here, but let's not leave
anyone wondering about _bfd_coff_free_cached_info.)

	* coffgen.c (_bfd_coff_free_cached_info): Ignore return status
	of _bfd_coff_free_symbols.
---

diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index dc5b0f40020..27bd54dcdd0 100644
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -3295,8 +3295,7 @@ _bfd_coff_free_cached_info (bfd *abfd)
 	 Do not clear the keep_syms and keep_strings flags.
 	 These may have been set by pe_ILF_build_a_bfd() indicating
 	 that the syms and strings pointers are not to be freed.  */
-      if (!_bfd_coff_free_symbols (abfd))
-	return false;
+      _bfd_coff_free_symbols (abfd);
     }
 
   return _bfd_generic_bfd_free_cached_info (abfd);