From: Miri Korenblit Date: Sun, 29 Dec 2024 14:44:45 +0000 (+0200) Subject: wifi: iwlwifi: mvm: fix iwl_ssid_exist() check X-Git-Tag: v6.14-rc1~162^2~20^2~69 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2ce67f8bf1ce;p=thirdparty%2Flinux.git wifi: iwlwifi: mvm: fix iwl_ssid_exist() check iwl_ssid_exist() seems to check if a given ssid/ssid_len already exists in a given array ssid_list. Correctly compare the ssid to the SSID of each array element (with a matching SSID length) to better remove duplicates. Signed-off-by: Bjoern A. Zeeb Sponsored by: The FreeBSD Foundation Signed-off-by: Miri Korenblit Reviewed-by: Emmanuel Grumbach Reviewed-by: Daniel Gabay Link: https://patch.msgid.link/20241229164246.4471cd3d8dba.Iab8409b22bf6f01d05571ecef1e97dd3c8b1cc75@changeid Signed-off-by: Johannes Berg --- diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c index 0bcd1fca31bcd..60bd9c7e5f03d 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c @@ -462,7 +462,7 @@ static int iwl_ssid_exist(u8 *ssid, u8 ssid_len, struct iwl_ssid_ie *ssid_list) if (!ssid_list[i].len) break; if (ssid_list[i].len == ssid_len && - !memcmp(ssid_list->ssid, ssid, ssid_len)) + !memcmp(ssid_list[i].ssid, ssid, ssid_len)) return i; } return -1;