From: Thomas Rast Date: Wed, 24 Apr 2013 13:54:36 +0000 (+0200) Subject: remote: check for superfluous arguments in 'git remote add' X-Git-Tag: v1.8.3-rc1~7^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2d2e3d25595c1bcd2259db5eb7604f196d35949f;p=thirdparty%2Fgit.git remote: check for superfluous arguments in 'git remote add' The 'git remote add' subcommand did not check for superfluous command line arguments. Make it so. Signed-off-by: Thomas Rast Signed-off-by: Junio C Hamano --- diff --git a/builtin/remote.c b/builtin/remote.c index 937484d7c7..5e54d367b8 100644 --- a/builtin/remote.c +++ b/builtin/remote.c @@ -178,7 +178,7 @@ static int add(int argc, const char **argv) argc = parse_options(argc, argv, NULL, options, builtin_remote_add_usage, 0); - if (argc < 2) + if (argc != 2) usage_with_options(builtin_remote_add_usage, options); if (mirror && master) diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index c23e8482f0..07eb378922 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -1020,7 +1020,7 @@ test_extra_arg () { " } -test_extra_arg -f add nick url +test_extra_arg add nick url test_extra_arg rename origin newname test_extra_arg remove origin test_extra_arg set-head origin master