From: Luis Henriques (SUSE) <luis.henriques@linux.dev>
Date: Mon, 27 May 2024 16:14:47 +0000 (+0100)
Subject: ext4: use ext4_update_inode_fsync_trans() helper in inode creation
X-Git-Tag: v6.11-rc1~122^2~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2d4d6bda0f7ba0f188a22698855a1397c8999df3;p=thirdparty%2Flinux.git

ext4: use ext4_update_inode_fsync_trans() helper in inode creation

Call helper function ext4_update_inode_fsync_trans() instead of open
coding it in __ext4_new_inode().  This helper checks both that the handle
is valid *and* that it hasn't been aborted due to some fatal error in the
journalling layer, using is_handle_aborted().

Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
Link: https://patch.msgid.link/20240527161447.21434-1-luis.henriques@linux.dev
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index e9bbb1da2d0a2..9dfd768ed9f8d 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -1336,10 +1336,7 @@ got:
 		}
 	}
 
-	if (ext4_handle_valid(handle)) {
-		ei->i_sync_tid = handle->h_transaction->t_tid;
-		ei->i_datasync_tid = handle->h_transaction->t_tid;
-	}
+	ext4_update_inode_fsync_trans(handle, inode, 1);
 
 	err = ext4_mark_inode_dirty(handle, inode);
 	if (err) {