From: Dan Carpenter Date: Thu, 5 Sep 2024 13:16:53 +0000 (+0300) Subject: platform: cznic: turris-omnia-mcu: Fix error check in omnia_mcu_register_trng() X-Git-Tag: v6.12-rc1~187^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2d516b8fc0f18ce9c0347a1aea6edb3d8ca1d692;p=thirdparty%2Fkernel%2Flinux.git platform: cznic: turris-omnia-mcu: Fix error check in omnia_mcu_register_trng() The gpiod_to_irq() function never returns zero. It returns negative error codes or a positive IRQ number. Update the checking to check for negatives. Fixes: 41bb142a4028 ("platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG") Signed-off-by: Dan Carpenter Reviewed-by: Marek Behún Signed-off-by: Arnd Bergmann --- diff --git a/drivers/platform/cznic/turris-omnia-mcu-trng.c b/drivers/platform/cznic/turris-omnia-mcu-trng.c index ad953fb3c37af..9a1d9292dc9ad 100644 --- a/drivers/platform/cznic/turris-omnia-mcu-trng.c +++ b/drivers/platform/cznic/turris-omnia-mcu-trng.c @@ -70,8 +70,8 @@ int omnia_mcu_register_trng(struct omnia_mcu *mcu) irq_idx = omnia_int_to_gpio_idx[__bf_shf(OMNIA_INT_TRNG)]; irq = gpiod_to_irq(gpio_device_get_desc(mcu->gc.gpiodev, irq_idx)); - if (!irq) - return dev_err_probe(dev, -ENXIO, "Cannot get TRNG IRQ\n"); + if (irq < 0) + return dev_err_probe(dev, irq, "Cannot get TRNG IRQ\n"); /* * If someone else cleared the TRNG interrupt but did not read the