From: Li Zetao <lizetao1@huawei.com>
Date: Thu, 22 Aug 2024 04:32:46 +0000 (+0800)
Subject: rtnetlink: delete redundant judgment statements
X-Git-Tag: v6.12-rc1~232^2~195^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2d522384fb5b8187cb7f8fe7d05c119ac38fd8f3;p=thirdparty%2Fkernel%2Flinux.git

rtnetlink: delete redundant judgment statements

The initial value of err is -ENOBUFS, and err is guaranteed to be
less than 0 before all goto errout. Therefore, on the error path
of errout, there is no need to repeatedly judge that err is less than 0,
and delete redundant judgments to make the code more concise.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 73fd7f543fd09..cd9487a12d1a3 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -4087,8 +4087,7 @@ struct sk_buff *rtmsg_ifinfo_build_skb(int type, struct net_device *dev,
 	}
 	return skb;
 errout:
-	if (err < 0)
-		rtnl_set_sk_err(net, RTNLGRP_LINK, err);
+	rtnl_set_sk_err(net, RTNLGRP_LINK, err);
 	return NULL;
 }