From: Gustavo A. R. Silva <gustavo@embeddedor.com>
Date: Mon, 26 Nov 2018 20:06:48 +0000 (-0600)
Subject: scsi: ppa: mark expected switch fall-through
X-Git-Tag: v5.2-rc1~156^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2d5ffc2611f45de5ada90047c5d8723a3b33db38;p=thirdparty%2Fkernel%2Flinux.git

scsi: ppa: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114988 ("Missing break in switch")
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---

diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c
index c182b5458f98c..35213082e933b 100644
--- a/drivers/scsi/ppa.c
+++ b/drivers/scsi/ppa.c
@@ -717,6 +717,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
 			}
 			cmd->SCp.phase++;
 		}
+		/* fall through */
 
 	case 2:		/* Phase 2 - We are now talking to the scsi bus */
 		if (!ppa_select(dev, scmd_id(cmd))) {