From: Max Gurtovoy <maxg@mellanox.com>
Date: Mon, 9 Mar 2020 15:04:12 +0000 (+0200)
Subject: nvme-pci: properly print controller address
X-Git-Tag: v5.7-rc1~202^2~3^2~19
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2db24e4a22bc97c713261a81fc75e2a36db65715;p=thirdparty%2Fkernel%2Flinux.git

nvme-pci: properly print controller address

Align PCI address print with fabrics address that is printed with
newline character.

Before:
[root@server40 linux]# cat /sys/class/nvme/nvme2/address
0000:0b:00.0[root@server40 linux]#

After:
[root@server40 linux]# cat /sys/class/nvme/nvme2/address
0000:0b:00.0
[root@server40 linux]#

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
---

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index f45e26e6af7e9..e6fa0c7bb96c2 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2656,7 +2656,7 @@ static int nvme_pci_get_address(struct nvme_ctrl *ctrl, char *buf, int size)
 {
 	struct pci_dev *pdev = to_pci_dev(to_nvme_dev(ctrl)->dev);
 
-	return snprintf(buf, size, "%s", dev_name(&pdev->dev));
+	return snprintf(buf, size, "%s\n", dev_name(&pdev->dev));
 }
 
 static const struct nvme_ctrl_ops nvme_pci_ctrl_ops = {