From: Christina Schimpe Date: Thu, 18 Sep 2025 09:07:59 +0000 (+0000) Subject: gdb, testsuite: Fix argument unused warning with clang X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2df7e2237ecb5e5def03407e12f4aa03bc70ebdd;p=thirdparty%2Fbinutils-gdb.git gdb, testsuite: Fix argument unused warning with clang Since clang 19 we see: ~~ clang: warning: argument unused during compilation: '-nostartfiles' [-Wunused-command-line-argument]^M gdb compile failed, clang: warning: argument unused during compilation: '-nostartfiles' [-Wunused-command-line-argument] UNTESTED: gdb.arch/amd64-init-x87-values.exp: failed to prepare ~~ Fix this by only passing '-nostartfiles' when linking. Approved-By: Tom Tromey --- diff --git a/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp b/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp index 871972c0426..5bbadaf2f5b 100644 --- a/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp +++ b/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp @@ -24,7 +24,7 @@ standard_testfile .S set options [list debug \ additional_flags=-static \ - additional_flags=-nostartfiles] + ldflags=-nostartfiles] if { [build_executable "failed to prepare" ${testfile} ${srcfile} $options] } { return -1 } diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-bad-cu-index.exp b/gdb/testsuite/gdb.dwarf2/debug-names-bad-cu-index.exp index 6fdb1b2ee68..016478f0080 100644 --- a/gdb/testsuite/gdb.dwarf2/debug-names-bad-cu-index.exp +++ b/gdb/testsuite/gdb.dwarf2/debug-names-bad-cu-index.exp @@ -21,7 +21,7 @@ require dwarf2_support standard_testfile _start.c debug-names.S set func_info_vars \ - [get_func_info _start [list debug additional_flags=-nostartfiles]] + [get_func_info _start [list debug ldflags=-nostartfiles]] # Create the DWARF. set asm_file [standard_output_file $srcfile2] @@ -76,7 +76,7 @@ Dwarf::assemble { } if {[build_executable ${testfile}.exp $testfile "${asm_file} ${srcfile}" \ - [list additional_flags=-nostartfiles]] == -1} { + [list ldflags=-nostartfiles]] == -1} { return -1 } diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp b/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp index 5c84480e157..28f21571184 100644 --- a/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp +++ b/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp @@ -21,7 +21,7 @@ require dwarf2_support standard_testfile _start.c debug-names.S set func_info_vars \ - [get_func_info _start [list debug additional_flags=-nostartfiles]] + [get_func_info _start [list debug ldflags=-nostartfiles]] # Create the DWARF. set asm_file [standard_output_file $srcfile2] @@ -60,7 +60,7 @@ Dwarf::assemble { } if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \ - [list additional_flags=-nostartfiles]] { + [list ldflags=-nostartfiles]] { return -1 } diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-missing-cu.exp b/gdb/testsuite/gdb.dwarf2/debug-names-missing-cu.exp index 64550abb06f..77db1442758 100644 --- a/gdb/testsuite/gdb.dwarf2/debug-names-missing-cu.exp +++ b/gdb/testsuite/gdb.dwarf2/debug-names-missing-cu.exp @@ -25,7 +25,7 @@ require !readnow standard_testfile _start.c debug-names.S set func_info_vars \ - [get_func_info _start [list debug additional_flags=-nostartfiles]] + [get_func_info _start [list debug ldflags=-nostartfiles]] # Create the DWARF. set asm_file [standard_output_file $srcfile2] @@ -67,7 +67,7 @@ Dwarf::assemble { } if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \ - [list additional_flags=-nostartfiles]] { + [list ldflags=-nostartfiles]] { return -1 } diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl b/gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl index 6ab6142f8a1..4de96ffe20e 100644 --- a/gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl +++ b/gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl @@ -25,7 +25,7 @@ require !readnow standard_testfile _start.c debug-names.S set func_info_vars \ - [get_func_info _start [list debug additional_flags=-nostartfiles]] + [get_func_info _start [list debug ldflags=-nostartfiles]] # Create the DWARF. set asm_file [standard_output_file $srcfile2] @@ -84,7 +84,7 @@ Dwarf::assemble { } if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \ - [list additional_flags=-nostartfiles]] { + [list ldflags=-nostartfiles]] { return -1 } diff --git a/gdb/testsuite/gdb.dwarf2/debug-names.exp b/gdb/testsuite/gdb.dwarf2/debug-names.exp index 5ef21a67255..7f63af29b43 100644 --- a/gdb/testsuite/gdb.dwarf2/debug-names.exp +++ b/gdb/testsuite/gdb.dwarf2/debug-names.exp @@ -21,7 +21,7 @@ require dwarf2_support standard_testfile _start.c debug-names.S set func_info_vars \ - [get_func_info _start [list debug additional_flags=-nostartfiles]] + [get_func_info _start [list debug ldflags=-nostartfiles]] # Create the DWARF. set asm_file [standard_output_file $srcfile2] @@ -59,7 +59,7 @@ Dwarf::assemble { } if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \ - [list additional_flags=-nostartfiles]] { + [list ldflags=-nostartfiles]] { return -1 } diff --git a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp index 47482a2e35f..23adbb03bb5 100644 --- a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp +++ b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp @@ -24,7 +24,7 @@ set opts {} lappend opts debug lappend opts additional_flags=-static lappend opts additional_flags=-nostdlib -lappend opts additional_flags=-nostartfiles +lappend opts ldflags=-nostartfiles if { [build_executable "failed to prepare" $testfile $srcfile $opts] == -1 } { return -1