From: bert hubert <bert.hubert@netherlabs.nl>
Date: Wed, 23 Apr 2014 07:09:26 +0000 (+0200)
Subject: Revert "appears to do something"
X-Git-Tag: rec-3.6.0-rc1~48
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2dfd6b650cf5af6bd419ab208f1f60ea626ecbe1;p=thirdparty%2Fpdns.git

Revert "appears to do something"

This reverts commit a2e9e5a5891f74ce4f15fa79395085915f449340.
---

diff --git a/pdns/Makefile.am b/pdns/Makefile.am
index 0bf2fd040c..5acc3b6f29 100644
--- a/pdns/Makefile.am
+++ b/pdns/Makefile.am
@@ -113,7 +113,7 @@ zone2sql_SOURCES=bindparser.yy bindlexer.l bind-dnssec.schema.sqlite3.sql.h \
 	zoneparser-tng.cc dnsrecords.cc sillyrecords.cc \
 	dnswriter.cc dnslabeltext.cc rcpgenerator.cc dnsparser.cc base64.cc \
 	nsecrecords.cc dnssecinfra.cc base32.cc bindparserclasses.hh \
-	dns_random.cc json.cc json.hh
+	dns_random.cc
 
 zone2sql_LDFLAGS=@THREADFLAGS@
 zone2sql_LDADD= $(POLARSSL_LIBS)
diff --git a/pdns/zone2sql.cc b/pdns/zone2sql.cc
index 15d1832107..250c31ec01 100644
--- a/pdns/zone2sql.cc
+++ b/pdns/zone2sql.cc
@@ -1,6 +1,6 @@
 /*
     PowerDNS Versatile Database Driven Nameserver
-    Copyright (C) 2002 - 2014  PowerDNS.COM BV
+    Copyright (C) 2002 - 2011  PowerDNS.COM BV
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License version 2
@@ -24,7 +24,7 @@
 #include <unistd.h>
 #include <string>
 #include <map>
-#include "json.hh"
+
 #include <iostream>
 #include <stdio.h>
 #include "namespaces.hh"
@@ -142,23 +142,8 @@ static void emitDomain(const string& domain, const vector<string> *masters = 0)
   }
 }
 
-static void emitRecord(const string& zoneName, const string &qname, const string &qtype, const string &ocontent, int ttl, int prio, const string& comment="")
+static void emitRecord(const string& zoneName, const string &qname, const string &qtype, const string &ocontent, int ttl, int prio)
 {
-  int disabled=0;
-  string recordcomment;
-
-  if(!comment.empty()) {
-    string::size_type pos = comment.find("json={");
-    if(pos!=string::npos) {
-      string json = comment.substr(pos+5);
-      rapidjson::Document document;
-      if(document.Parse<0>(json.c_str()).HasParseError())
-	throw runtime_error("Could not parse JSON '"+json+"'");
-
-      disabled=boolFromJson(document, "disabled", false);
-      recordcomment=stringFromJson(document, "comment", "");
-    }
-  }
   g_numRecords++;
   string content(ocontent);
 
@@ -184,22 +169,15 @@ static void emitRecord(const string& zoneName, const string &qname, const string
       cout<<"insert into records (domain_id, name, type,content,ttl,prio,disabled) select id ,"<<
         sqlstr(toLower(stripDot(qname)))<<", "<<
         sqlstr(qtype)<<", "<<
-        sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", "<<disabled<<
+        sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", 0"<<
         " from domains where name="<<toLower(sqlstr(zoneName))<<";\n";
-
-      if(!recordcomment.empty()) {
-	cout<<"insert into comments (domain_id,name,type,modified_at, comment) select id, "<<toLower(sqlstr(zoneName))<<", "<<sqlstr(qtype)<<", "<<time(0)<<", "<<sqlstr(recordcomment)<<" from domains where name="<<toLower(sqlstr(zoneName))<<";\n";
-       
-      }
-
-
     } else
     {
       cout<<"insert into records (domain_id, name, ordername, auth, type,content,ttl,prio,disabled) select id ,"<<
         sqlstr(toLower(stripDot(qname)))<<", "<<
         sqlstr(toLower(labelReverse(makeRelative(stripDot(qname), zoneName))))<<", "<<auth<<", "<<
         sqlstr(qtype)<<", "<<
-        sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", "<<disabled<<
+        sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", 0"<<
         " from domains where name="<<toLower(sqlstr(zoneName))<<";\n";
     }
   }
@@ -208,7 +186,7 @@ static void emitRecord(const string& zoneName, const string &qname, const string
       cout<<"insert into records (domain_id, name,type,content,ttl,prio,disabled) select id ,"<<
         sqlstr(toLower(stripDot(qname)))<<", "<<
         sqlstr(qtype)<<", "<<
-        sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", "<< (disabled ? 't': 'f')<<
+        sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", 'f'"<<
         " from domains where name="<<toLower(sqlstr(zoneName))<<";\n";
     } else
     {
@@ -216,7 +194,7 @@ static void emitRecord(const string& zoneName, const string &qname, const string
         sqlstr(toLower(stripDot(qname)))<<", "<<
         sqlstr(toLower(labelReverse(makeRelative(stripDot(qname), zoneName))))<<", '"<< (auth  ? 't' : 'f') <<"', "<<
         sqlstr(qtype)<<", "<<
-        sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", "<<(disabled ? 't': 'f') <<
+        sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", 'f'"<<
         " from domains where name="<<toLower(sqlstr(zoneName))<<";\n";
     }
   }
@@ -224,7 +202,7 @@ static void emitRecord(const string& zoneName, const string &qname, const string
     cout<<"insert into Records (id, domain_id, name, type, content, ttl, prio, disabled) select RECORDS_ID_SEQUENCE.nextval,id ,"<<
       sqlstr(toLower(stripDot(qname)))<<", "<<
       sqlstr(qtype)<<", "<<
-      sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", "<<disabled<<
+      sqlstr(stripDotContent(content))<<", "<<ttl<<", "<<prio<<", 0"
       " from Domains where name="<<toLower(sqlstr(zoneName))<<";\n";
   }
   else if(g_mode==ORACLE) {
@@ -411,12 +389,8 @@ try
       DNSResourceRecord rr;
       startNewTransaction();
       emitDomain(zonename);
-      string comment;
-      
-      while(zpt.get(rr, &comment))  {
-	
-        emitRecord(zonename, rr.qname, rr.qtype.getName(), rr.content, rr.ttl, rr.priority, comment);
-      }
+      while(zpt.get(rr)) 
+        emitRecord(zonename, rr.qname, rr.qtype.getName(), rr.content, rr.ttl, rr.priority);
       num_domainsdone=1;
     }
     cerr<<num_domainsdone<<" domains were fully parsed, containing "<<g_numRecords<<" records\n";
diff --git a/pdns/zoneparser-tng.cc b/pdns/zoneparser-tng.cc
index ff6a3e8f2e..c241e90f67 100644
--- a/pdns/zoneparser-tng.cc
+++ b/pdns/zoneparser-tng.cc
@@ -35,7 +35,7 @@
 
 ZoneParserTNG::ZoneParserTNG(const string& fname, const string& zname, const string& reldir) : d_reldir(reldir), 
                                                                                                d_zonename(zname), d_defaultttl(3600), 
-                                                                                               d_havedollarttl(false), d_doPassComments(0)
+                                                                                               d_havedollarttl(false)
 {
   d_zonename = toCanonic("", d_zonename);
   stackFile(fname);
@@ -230,17 +230,14 @@ string ZoneParserTNG::getLineOfFile()
 }
 
 // ODD: this function never fills out the prio field! rest of pdns compensates though
-bool ZoneParserTNG::get(DNSResourceRecord& rr, std::string* comment) 
+bool ZoneParserTNG::get(DNSResourceRecord& rr) 
 {
  retry:;
   if(!getTemplateLine() && !getLine())
     return false;
 
   boost::trim_right_if(d_line, is_any_of(" \r\n\x1a"));
-  if(comment)
-    comment->clear();
-  if(comment && d_line.find(';') != string::npos)
-    *comment = d_line.substr(d_line.find(';'));
+
   parts_t parts;
   vstringtok(parts, d_line);
 
@@ -317,9 +314,8 @@ bool ZoneParserTNG::get(DNSResourceRecord& rr, std::string* comment)
     if(nextpart.empty())
       break;
 
-    if(nextpart.find(';')!=string::npos) {
+    if(nextpart.find(';')!=string::npos)
       break;
-    }
 
     // cout<<"Next part: '"<<nextpart<<"'"<<endl;
     
diff --git a/pdns/zoneparser-tng.hh b/pdns/zoneparser-tng.hh
index 8a865d30b2..8d5b23860f 100644
--- a/pdns/zoneparser-tng.hh
+++ b/pdns/zoneparser-tng.hh
@@ -35,8 +35,8 @@ public:
   ZoneParserTNG(const string& fname, const string& zname="", const string& reldir="");
 
   ~ZoneParserTNG();
-  void enableComments();
-  bool get(DNSResourceRecord& rr, std::string* comment=0);
+
+  bool get(DNSResourceRecord& rr);
   typedef runtime_error exception;
   typedef deque<pair<string::size_type, string::size_type> > parts_t;
 private:
@@ -54,7 +54,6 @@ private:
   uint32_t d_templatecounter, d_templatestop, d_templatestep;
   string d_templateline;
   parts_t d_templateparts;
-  bool d_doPassComments;
 
   struct filestate {
     filestate(FILE* fp, string filename) : d_fp(fp), d_filename(filename), d_lineno(0){}