From: Dan Carpenter Date: Wed, 11 Sep 2024 07:39:59 +0000 (+0300) Subject: perf: arm-ni: Fix an NULL vs IS_ERR() bug X-Git-Tag: v6.12-rc1~221^2~4^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2e091a805febb9a91cc7de2735d8d4ef0e640241;p=thirdparty%2Flinux.git perf: arm-ni: Fix an NULL vs IS_ERR() bug The devm_ioremap() function never returns error pointers, it returns a NULL pointer if there is an error. Fixes: 4d5a7680f2b4 ("perf: Add driver for Arm NI-700 interconnect PMU") Signed-off-by: Dan Carpenter Reviewed-by: Robin Murphy Link: https://lore.kernel.org/r/04d6ccc3-6d31-4f0f-ab0f-7a88342cc09a@stanley.mountain Signed-off-by: Will Deacon --- diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c index b72df3aea93e3..90fcfe693439e 100644 --- a/drivers/perf/arm-ni.c +++ b/drivers/perf/arm-ni.c @@ -603,8 +603,8 @@ static int arm_ni_probe(struct platform_device *pdev) */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); - if (IS_ERR(base)) - return PTR_ERR(base); + if (!base) + return -ENOMEM; arm_ni_probe_domain(base, &cfg); if (cfg.type != NI_GLOBAL)