From: Tavian Barnes <tavianator@tavianator.com>
Date: Fri, 21 Jun 2024 20:29:32 +0000 (-0400)
Subject: bcachefs: darray: Don't pass NULL to memcpy()
X-Git-Tag: v6.11-rc1~120^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2e118ba36d56acf78084518dfb7cb53b1d417da0;p=thirdparty%2Fkernel%2Flinux.git

bcachefs: darray: Don't pass NULL to memcpy()

memcpy's second parameter must not be NULL, even if size is zero.

Signed-off-by: Tavian Barnes <tavianator@tavianator.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/darray.c b/fs/bcachefs/darray.c
index ac35b8b705ae1..b7d223f85873e 100644
--- a/fs/bcachefs/darray.c
+++ b/fs/bcachefs/darray.c
@@ -13,7 +13,8 @@ int __bch2_darray_resize(darray_char *d, size_t element_size, size_t new_size, g
 		if (!data)
 			return -ENOMEM;
 
-		memcpy(data, d->data, d->size * element_size);
+		if (d->size)
+			memcpy(data, d->data, d->size * element_size);
 		if (d->data != d->preallocated)
 			kvfree(d->data);
 		d->data	= data;