From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 4 May 2017 13:59:13 +0000 (+0200)
Subject: show_worktree(): plug memory leak
X-Git-Tag: v2.13.1~27^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2e11f58fa6a0c904d9b00e51cfb2d8a3ee77b360;p=thirdparty%2Fgit.git

show_worktree(): plug memory leak

The buffer allocated by shorten_unambiguous_ref() needs to be released.

Discovered by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/worktree.c b/builtin/worktree.c
index 1722a9bdc2..ff5dfd2b10 100644
--- a/builtin/worktree.c
+++ b/builtin/worktree.c
@@ -414,9 +414,11 @@ static void show_worktree(struct worktree *wt, int path_maxlen, int abbrev_len)
 				find_unique_abbrev(wt->head_sha1, DEFAULT_ABBREV));
 		if (wt->is_detached)
 			strbuf_addstr(&sb, "(detached HEAD)");
-		else if (wt->head_ref)
-			strbuf_addf(&sb, "[%s]", shorten_unambiguous_ref(wt->head_ref, 0));
-		else
+		else if (wt->head_ref) {
+			char *ref = shorten_unambiguous_ref(wt->head_ref, 0);
+			strbuf_addf(&sb, "[%s]", ref);
+			free(ref);
+		} else
 			strbuf_addstr(&sb, "(error)");
 	}
 	printf("%s\n", sb.buf);