From: Wolfgang Stöggl <c72578@yahoo.de>
Date: Mon, 8 Jul 2019 12:06:28 +0000 (+0200)
Subject: Fix identical inner if condition rrd_graph_helper
X-Git-Tag: v1.8.0~79
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2e356b25758af3de93414f3b42630f07f1592c8f;p=thirdparty%2Frrdtool-1.x.git

Fix identical inner if condition rrd_graph_helper

- Fixes the following Cppcheck warning:
  [src/rrd_graph_helper.c:972] (warning) Identical inner 'if' condition
  is always true
  (outer condition is '!vname' and inner condition is '!vname').
  [identicalInnerCondition]
---

diff --git a/src/rrd_graph_helper.c b/src/rrd_graph_helper.c
index b1d03e4f..dde3e0ac 100644
--- a/src/rrd_graph_helper.c
+++ b/src/rrd_graph_helper.c
@@ -969,9 +969,7 @@ static graph_desc_t *newGraphDescription(
             }
             dprintfparsed("got positional vname and rrd: %s - %s\n",
                           first->key, first->value);
-            if (!vname) {
-                vname = first->value;
-            }
+            vname = first->value;
         }
     }