From: Richard Henderson <richard.henderson@linaro.org>
Date: Sun, 8 Dec 2024 19:51:04 +0000 (-0600)
Subject: target/hexagon: Use float32_muladd for helper_sffms
X-Git-Tag: v10.0.0-rc0~107^2~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2eca1928f9afb7cbc8e72a59dffb964c8319469a;p=thirdparty%2Fqemu.git

target/hexagon: Use float32_muladd for helper_sffms

There are no special cases for this instruction.  Since hexagon
always uses default-nan mode, explicitly negating the first
input is unnecessary.  Use float_muladd_negate_product instead.

Reviewed-by: Brian Cain <brian.cain@oss.qualcomm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c
index 15b143a5688..95bfa5d0299 100644
--- a/target/hexagon/op_helper.c
+++ b/target/hexagon/op_helper.c
@@ -1096,10 +1096,9 @@ float32 HELPER(sffma_sc)(CPUHexagonState *env, float32 RxV,
 float32 HELPER(sffms)(CPUHexagonState *env, float32 RxV,
                       float32 RsV, float32 RtV)
 {
-    float32 neg_RsV;
     arch_fpop_start(env);
-    neg_RsV = float32_set_sign(RsV, float32_is_neg(RsV) ? 0 : 1);
-    RxV = internal_fmafx(neg_RsV, RtV, RxV, 0, &env->fp_status);
+    RxV = float32_muladd(RsV, RtV, RxV, float_muladd_negate_product,
+                         &env->fp_status);
     arch_fpop_end(env);
     return RxV;
 }