From: Tom de Vries Date: Mon, 6 Jan 2025 09:04:22 +0000 (+0100) Subject: [gdb/build] Use const_cast in fd_copy X-Git-Tag: gdb-16.1-release~21 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2efabd1d9bf0b306380307fafc5efbe2ec6faf9f;p=thirdparty%2Fbinutils-gdb.git [gdb/build] Use const_cast in fd_copy Recent commit 6ab5d62ebc5 ("[gdb] Fix compilation error in event-top.c") did: ... fd_copy (fd_set *dst, const fd_set *src, int n) { FD_ZERO (dst); for (int i = 0; i < n; ++i) - if (FD_ISSET (i, src)) + if (FD_ISSET (i, (fd_set *)src)) ... but according to [1] only const_cast may be used to cast away constness. Fix this by using const_cast. Tested by rebuilding on x86_64-linux. [1] https://en.cppreference.com/w/cpp/language/const_cast (cherry picked from commit a189db13c4889548be4439314a956f2ab910166b) --- diff --git a/gdb/event-top.c b/gdb/event-top.c index 5fa53bf8bdc..1fe37841935 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -1276,7 +1276,7 @@ fd_copy (fd_set *dst, const fd_set *src, int n) { FD_ZERO (dst); for (int i = 0; i < n; ++i) - if (FD_ISSET (i, (fd_set *)src)) + if (FD_ISSET (i, const_cast(src))) FD_SET (i, dst); return dst;