From: Christopher Faulet <cfaulet@haproxy.com>
Date: Tue, 19 Mar 2019 13:55:11 +0000 (+0100)
Subject: BUG/MINOR: proto-http: Don't forward request body anymore on error
X-Git-Tag: v2.0-dev2~18
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2f5c7848644792640f3957a9b40cb77038bf15c9;p=thirdparty%2Fhaproxy.git

BUG/MINOR: proto-http: Don't forward request body anymore on error

In the commit 93e02d8b7 ("MINOR: proto-http/proto-htx: Make error handling
clearer during data forwarding"), a return clause was removed by error in the
function http_request_forward_body(). This bug seems not having any visible
impact.

This patch must be backported to 1.9.
---

diff --git a/src/proto_http.c b/src/proto_http.c
index 85e007b496..9ba0eb594d 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -3992,6 +3992,7 @@ int http_request_forward_body(struct stream *s, struct channel *req, int an_bit)
 		msg->err_state = msg->msg_state;
 		msg->msg_state = HTTP_MSG_ERROR;
 		http_resync_states(s);
+		return 1;
 	}
 
 	/* Note that we don't have to send 100-continue back because we don't