From: Cédric Le Goater Date: Mon, 15 Dec 2025 10:19:34 +0000 (+0100) Subject: i386: Fix const qualifier build errors with recent glibc X-Git-Tag: v10.2.0-rc4~2^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2f5c96d53409160b11f031b22f2d947f75ab06ab;p=thirdparty%2Fqemu.git i386: Fix const qualifier build errors with recent glibc A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in : ../hw/i386/x86-common.c:827:11: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 827 | vmode = strstr(kernel_cmdline, "vga="); | ^ Fix this by changing the type of the variables that store the result of these functions to 'const char *'. [1] https://sourceware.org/git/?p=glibc.git;a=commit;h=cd748a63ab1a7ae846175c532a3daab341c62690 Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Link: https://lore.kernel.org/qemu-devel/20251215101937.281722-2-clg@redhat.com Signed-off-by: Cédric Le Goater --- diff --git a/hw/i386/x86-common.c b/hw/i386/x86-common.c index c844749900..f77e2e6304 100644 --- a/hw/i386/x86-common.c +++ b/hw/i386/x86-common.c @@ -654,7 +654,7 @@ void x86_load_linux(X86MachineState *x86ms, uint8_t header[8192], *setup, *kernel; hwaddr real_addr, prot_addr, cmdline_addr, initrd_addr = 0; FILE *f; - char *vmode; + const char *vmode; MachineState *machine = MACHINE(x86ms); struct setup_data *setup_data; const char *kernel_filename = machine->kernel_filename;