From: Dan Carpenter Date: Mon, 16 Sep 2024 14:07:10 +0000 (+0300) Subject: io_uring: clean up a type in io_uring_register_get_file() X-Git-Tag: v6.12-rc1~74^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2f6a55e4235f596b7dd9e8a7cf3e07f39ac5e9c2;p=thirdparty%2Fkernel%2Flinux.git io_uring: clean up a type in io_uring_register_get_file() Originally "fd" was unsigned int but it was changed to int when we pulled this code into a separate function in commit 0b6d253e084a ("io_uring/register: provide helper to get io_ring_ctx from 'fd'"). This doesn't really cause a runtime problem because the call to array_index_nospec() will clamp negative fds to 0 and nothing else uses the negative values. Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/6f6cb630-079f-4fdf-bf95-1082e0a3fc6e@stanley.mountain Signed-off-by: Jens Axboe --- diff --git a/io_uring/register.c b/io_uring/register.c index b8a48a6a89ee5..eca26d4884d9a 100644 --- a/io_uring/register.c +++ b/io_uring/register.c @@ -561,7 +561,7 @@ static int __io_uring_register(struct io_ring_ctx *ctx, unsigned opcode, * true, then the registered index is used. Otherwise, the normal fd table. * Caller must call fput() on the returned file, unless it's an ERR_PTR. */ -struct file *io_uring_register_get_file(int fd, bool registered) +struct file *io_uring_register_get_file(unsigned int fd, bool registered) { struct file *file; diff --git a/io_uring/register.h b/io_uring/register.h index cc69b88338fe3..a5f39d5ef9e0e 100644 --- a/io_uring/register.h +++ b/io_uring/register.h @@ -4,6 +4,6 @@ int io_eventfd_unregister(struct io_ring_ctx *ctx); int io_unregister_personality(struct io_ring_ctx *ctx, unsigned id); -struct file *io_uring_register_get_file(int fd, bool registered); +struct file *io_uring_register_get_file(unsigned int fd, bool registered); #endif