From: Ping-Ke Shih Date: Mon, 17 Feb 2025 06:43:05 +0000 (+0800) Subject: wifi: rtw89: fw: get sb_sel_ver via get_unaligned_le32() X-Git-Tag: v6.15-rc1~160^2~20^2~2^2~35 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2f9da853f4d848d23bade4c22931ea0f5a011674;p=thirdparty%2Flinux.git wifi: rtw89: fw: get sb_sel_ver via get_unaligned_le32() The sb_sel_ver is selection version for secure boot recorded in firmware binary data, and its size is 4 and offset is 58 (not natural alignment). Use get_unaligned_le32() to get this value safely. Find this by reviewing. Signed-off-by: Ping-Ke Shih Link: https://patch.msgid.link/20250217064308.43559-3-pkshih@realtek.com --- diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c index e4231dd620e6e..0a129476171a1 100644 --- a/drivers/net/wireless/realtek/rtw89/fw.c +++ b/drivers/net/wireless/realtek/rtw89/fw.c @@ -324,7 +324,7 @@ static int __parse_formatted_mssc(struct rtw89_dev *rtwdev, if (!sec->secure_boot) goto out; - sb_sel_ver = le32_to_cpu(section_content->sb_sel_ver.v); + sb_sel_ver = get_unaligned_le32(§ion_content->sb_sel_ver.v); if (sb_sel_ver && sb_sel_ver != sec->sb_sel_mgn) goto ignore;