From: Amit Shah <amit.shah@redhat.com>
Date: Mon, 4 May 2009 12:32:04 +0000 (+0530)
Subject: e1000: Do not reinit pci config space to 0
X-Git-Tag: v0.10.4~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2fd0f9328634d0b156add2b4d7c10f7c193d2e20;p=thirdparty%2Fqemu.git

e1000: Do not reinit pci config space to 0

pci_register_device already mallocs the pci config space buffer filled
with zeroes.

Doing this again breaks some default config space writes like
setting the subsystem vendor id and subsystem device id.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/hw/e1000.c b/hw/e1000.c
index b0fe917342b..940e893ba32 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1067,7 +1067,6 @@ pci_e1000_init(PCIBus *bus, NICInfo *nd, int devfn)
 	return NULL;
 
     pci_conf = d->dev.config;
-    memset(pci_conf, 0, 256);
 
     pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_INTEL);
     pci_config_set_device_id(pci_conf, E1000_DEVID);