From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 26 Aug 2025 15:04:07 +0000 (+0200)
Subject: dnsdist: Try to appease clang-tidy
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=2fddc9ea1454004b675510675aa27014ae6c7cc2;p=thirdparty%2Fpdns.git

dnsdist: Try to appease clang-tidy

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
index 1485f11d13..0cc8025c31 100644
--- a/pdns/dnsdistdist/dnsdist.cc
+++ b/pdns/dnsdistdist/dnsdist.cc
@@ -1448,10 +1448,12 @@ ProcessQueryResult processQueryAfterRules(DNSQuestion& dnsQuestion, std::shared_
     }
 
     bool willBeForwardedOverUDP = !dnsQuestion.overTCP() || dnsQuestion.ids.protocol == dnsdist::Protocol::DoH;
-    if (selectedBackend && selectedBackend->isTCPOnly()) {
-      willBeForwardedOverUDP = false;
+    if (selectedBackend) {
+      if (selectedBackend->isTCPOnly()) {
+        willBeForwardedOverUDP = false;
+      }
     }
-    else if (!selectedBackend && serverPool.isTCPOnly()) {
+    else if (serverPool.isTCPOnly()) {
       willBeForwardedOverUDP = false;
     }