From: Martin Schwenke <martin@meltin.net>
Date: Tue, 3 Mar 2020 06:48:40 +0000 (+1100)
Subject: ctdb-tests: Use ctdb_test_skip() when shellcheck is not installed
X-Git-Tag: ldb-2.2.0~1469
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=30180ef6c280a7aa3d683ae33877daa60ce6b3dd;p=thirdparty%2Fsamba.git

ctdb-tests: Use ctdb_test_skip() when shellcheck is not installed

When the tests are run interactively this will make it more noticeable
that shellcheck is not installed because the test summary will
indicate missing tests.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/tests/UNIT/shellcheck/scripts/local.sh b/ctdb/tests/UNIT/shellcheck/scripts/local.sh
index 84019144009..6bc93fd9146 100644
--- a/ctdb/tests/UNIT/shellcheck/scripts/local.sh
+++ b/ctdb/tests/UNIT/shellcheck/scripts/local.sh
@@ -31,7 +31,7 @@ shellcheck_test ()
 		_excludes="SC1090,SC1091,SC2162,SC2164"
 		unit_test shellcheck --exclude="$_excludes" "$@"
 	else
-		echo "WARNING: shellcheck not installed, skipping test"
+		ctdb_test_skip "shellcheck not installed"
 		unit_test true
 	fi
 }