From: Jake Moroni Date: Sun, 18 Feb 2018 20:26:04 +0000 (-0500) Subject: dpaa_eth: fix pause capability advertisement logic X-Git-Tag: v4.17-rc1~148^2~404 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3021efb440d02bf5b952b6d151c7ffee9bdd49fe;p=thirdparty%2Flinux.git dpaa_eth: fix pause capability advertisement logic The ADVERTISED_Asym_Pause bit was being improperly set when both rx and tx pause were enabled. When rx and tx are both enabled, only the ADVERTISED_Pause bit is supposed to be set. Signed-off-by: Jake Moroni Acked-by: Madalin Bucur Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c index faea674094b96..85306d1b2acf5 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c @@ -211,7 +211,7 @@ static int dpaa_set_pauseparam(struct net_device *net_dev, if (epause->rx_pause) newadv = ADVERTISED_Pause | ADVERTISED_Asym_Pause; if (epause->tx_pause) - newadv |= ADVERTISED_Asym_Pause; + newadv ^= ADVERTISED_Asym_Pause; oldadv = phydev->advertising & (ADVERTISED_Pause | ADVERTISED_Asym_Pause);