From: Abhay Kandpal Date: Thu, 25 Sep 2025 09:55:02 +0000 (-0500) Subject: PowerPC: Fix typo in PowerPC note pseudo-section names X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=30300ceca334a1a8997809b41ee7550bafa29b71;p=thirdparty%2Fbinutils-gdb.git PowerPC: Fix typo in PowerPC note pseudo-section names The recent tidy-up commit 09e56f0515c3 ("Code tidy: bfd/elf.c: Tidy up core note handling code.") introduced regressions in the PowerPC core note handling. The pseudo-section names for TM_CVSX, TM_SPR, VSX and VMX notes were defined with an underscore instead of a hyphen, breaking GDB test cases. The same goes for one riscv and one s390 define. This patch restores the correct section names by using hyphens in the definitions, fixing 897 GDB test failures on PowerPC. bfd/ * elf.c: (NOTE_PSEUDO_SECTION_PPC_TM_CVSX), (NOTE_PSEUDO_SECTION_PPC_TM_SPR, NOTE_PSEUDO_SECTION_PPC_VSX), (NOTE_PSEUDO_SECTION_PPC_VMX, NOTE_PSEUDO_SECTION_RISCV_CSR), (NOTE_PSEUDO_SECTION_S390_CTRS): Use hyphens in section names instead of underscores. --- diff --git a/bfd/elf.c b/bfd/elf.c index 6ef60301091..bde7414ee21 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -89,14 +89,14 @@ SECTION #define NOTE_PSEUDO_SECTION_PPC_TM_CPPR ".reg-ppc-tm-cppr" #define NOTE_PSEUDO_SECTION_PPC_TM_CTAR ".reg-ppc-tm-ctar" #define NOTE_PSEUDO_SECTION_PPC_TM_CVMX ".reg-ppc-tm-cvmx" -#define NOTE_PSEUDO_SECTION_PPC_TM_CVSX ".reg_ppc_tm_cvsx" -#define NOTE_PSEUDO_SECTION_PPC_TM_SPR ".reg_ppc_tm_spr" -#define NOTE_PSEUDO_SECTION_PPC_VSX ".reg_ppc_vsx" -#define NOTE_PSEUDO_SECTION_PPC_VMX ".reg_ppc_vmx" +#define NOTE_PSEUDO_SECTION_PPC_TM_CVSX ".reg-ppc-tm-cvsx" +#define NOTE_PSEUDO_SECTION_PPC_TM_SPR ".reg-ppc-tm-spr" +#define NOTE_PSEUDO_SECTION_PPC_VSX ".reg-ppc-vsx" +#define NOTE_PSEUDO_SECTION_PPC_VMX ".reg-ppc-vmx" #define NOTE_PSEUDO_SECTION_REG ".reg" #define NOTE_PSEUDO_SECTION_REG2 ".reg2" -#define NOTE_PSEUDO_SECTION_RISCV_CSR ".reg_riscv_csr" -#define NOTE_PSEUDO_SECTION_S390_CTRS ".reg_s390_ctrs" +#define NOTE_PSEUDO_SECTION_RISCV_CSR ".reg-riscv-csr" +#define NOTE_PSEUDO_SECTION_S390_CTRS ".reg-s390-ctrs" #define NOTE_PSEUDO_SECTION_S390_GS_BC ".reg-s390-gs-bc" #define NOTE_PSEUDO_SECTION_S390_GS_CB ".reg-s390-gs-cb" #define NOTE_PSEUDO_SECTION_S390_HIGH_GPRS ".reg-s390-high-gprs"