From: Steve Baird <baird@adacore.com>
Date: Tue, 9 Jul 2024 23:54:59 +0000 (-0700)
Subject: ada: Compiler accepts illegal assignment to reference type target.
X-Git-Tag: basepoints/gcc-16~6882
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=30ba62d91ff96b0f86cc1a8544dd1ed30196ca40;p=thirdparty%2Fgcc.git

ada: Compiler accepts illegal assignment to reference type target.

An assignment statement whose LHS is of a reference type is never legal. If
no other legality rule is violated, then it is ambiguous. In some cases this
ambiguity was not correctly detected.

gcc/ada/

	* sem_ch5.adb (Analyze_Assignment): Delete code that was
	incorrectly implementing a preference rule.
---

diff --git a/gcc/ada/sem_ch5.adb b/gcc/ada/sem_ch5.adb
index 4db3a1a26ee..d44a12d1dd1 100644
--- a/gcc/ada/sem_ch5.adb
+++ b/gcc/ada/sem_ch5.adb
@@ -437,14 +437,6 @@ package body Sem_Ch5 is
                then
                   null;
 
-               --  This may be a call to a parameterless function through an
-               --  implicit dereference, so discard interpretation as well.
-
-               elsif Is_Entity_Name (Lhs)
-                 and then Has_Implicit_Dereference (It.Typ)
-               then
-                  null;
-
                elsif Has_Compatible_Type (Rhs, It.Typ) then
                   if T1 = Any_Type then
                      T1 := It.Typ;