From: Eric Wong Date: Sun, 14 Sep 2014 07:38:29 +0000 (+0000) Subject: git-svn: delay term initialization X-Git-Tag: v2.2.0-rc0~124 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=30d45f798d;p=thirdparty%2Fgit.git git-svn: delay term initialization On my Debian 7 system, this fixes annoying warnings when the output of "git svn" commands are redirected: Unable to get Terminal Size. The TIOCGWINSZ ioctl didn't work. The COLUMNS and LINES environment variables didn't work. The resize program didn't work. Signed-off-by: Eric Wong --- diff --git a/git-svn.perl b/git-svn.perl index 97ff562843..b6e2186cef 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -306,13 +306,16 @@ sub readline { } package main; -my $term = eval { - $ENV{"GIT_SVN_NOTTY"} - ? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT - : new Term::ReadLine 'git-svn'; -}; -if ($@) { - $term = new FakeTerm "$@: going non-interactive"; +my $term; +sub term_init { + $term = eval { + $ENV{"GIT_SVN_NOTTY"} + ? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT + : new Term::ReadLine 'git-svn'; + }; + if ($@) { + $term = new FakeTerm "$@: going non-interactive"; + } } my $cmd; @@ -424,6 +427,7 @@ sub ask { my $default = $arg{default}; my $resp; my $i = 0; + term_init() unless $term; if ( !( defined($term->IN) && defined( fileno($term->IN) )