From: Karel Zak <kzak@redhat.com>
Date: Wed, 25 Nov 2020 13:02:11 +0000 (+0100)
Subject: lslogins: call close() for usable FD [coverity scan]
X-Git-Tag: v2.37-rc1~267
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=30e8df968f42ccf81638b9f81568a8d5298738a8;p=thirdparty%2Futil-linux.git

lslogins: call close() for usable FD [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/login-utils/lslogins.c b/login-utils/lslogins.c
index 8a6ef713fa..773d13a953 100644
--- a/login-utils/lslogins.c
+++ b/login-utils/lslogins.c
@@ -1654,7 +1654,9 @@ int main(int argc, char *argv[])
 
 	scols_unref_table(tb);
 	tdestroy(ctl->usertree, free_user);
-	close(ctl->lastlogin_fd);
+
+	if (ctl->lastlogin_fd >= 0)
+		close(ctl->lastlogin_fd);
 	free_ctl(ctl);
 
 	return EXIT_SUCCESS;