From: Li Qiang <liq3ea@gmail.com>
Date: Tue, 25 Sep 2018 19:01:27 +0000 (-0600)
Subject: vfio/pci: Fix potential memory leak in vfio_msi_cap_len
X-Git-Tag: v4.20-rc1~50^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=30ea32ab1951c80c6113f300fce2c70cd12659e4;p=thirdparty%2Flinux.git

vfio/pci: Fix potential memory leak in vfio_msi_cap_len

Free allocated vdev->msi_perm in error path.

Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
index 115a36f6f4039..62023b4a373b4 100644
--- a/drivers/vfio/pci/vfio_pci_config.c
+++ b/drivers/vfio/pci/vfio_pci_config.c
@@ -1180,8 +1180,10 @@ static int vfio_msi_cap_len(struct vfio_pci_device *vdev, u8 pos)
 		return -ENOMEM;
 
 	ret = init_pci_cap_msi_perm(vdev->msi_perm, len, flags);
-	if (ret)
+	if (ret) {
+		kfree(vdev->msi_perm);
 		return ret;
+	}
 
 	return len;
 }