From: Jaroslav Kysela <perex@perex.cz>
Date: Tue, 30 Jan 2018 18:19:36 +0000 (+0100)
Subject: dvb psi: remove mpegts_psi_table_state_skel (atomicity problem)
X-Git-Tag: v4.2.6~35
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3121f34c2a7af2fccaa406351b3d5fa7e6d79628;p=thirdparty%2Ftvheadend.git

dvb psi: remove mpegts_psi_table_state_skel (atomicity problem)
---

diff --git a/src/input/mpegts/dvb_psi_lib.c b/src/input/mpegts/dvb_psi_lib.c
index e342daf6d..b22ae8a99 100644
--- a/src/input/mpegts/dvb_psi_lib.c
+++ b/src/input/mpegts/dvb_psi_lib.c
@@ -21,8 +21,6 @@
 #include "input.h"
 #include "dvb.h"
 
-SKEL_DECLARE(mpegts_psi_table_state_skel, struct mpegts_psi_table_state);
-
 /* **************************************************************************
  * Lookup tables
  * *************************************************************************/
@@ -214,19 +212,21 @@ static mpegts_psi_table_state_t *
 mpegts_table_state_find
   ( mpegts_psi_table_t *mt, int tableid, uint64_t extraid, int last )
 {
-  mpegts_psi_table_state_t *st;
+  mpegts_psi_table_state_t *st, *st2, st_cmp;
 
   /* Find state */
-  SKEL_ALLOC(mpegts_psi_table_state_skel);
-  mpegts_psi_table_state_skel->tableid = tableid;
-  mpegts_psi_table_state_skel->extraid = extraid;
-  st = RB_INSERT_SORTED(&mt->mt_state, mpegts_psi_table_state_skel, link, sect_cmp);
-  if (!st) {
-    st   = mpegts_psi_table_state_skel;
-    SKEL_USED(mpegts_psi_table_state_skel);
-    mt->mt_incomplete++;
-    mpegts_table_state_reset(mt, st, last);
-  }
+  st_cmp.tableid = tableid;
+  st_cmp.extraid = extraid;
+  st = RB_FIND(&mt->mt_state, &st_cmp, link, sect_cmp);
+  if (st)
+    return st;
+  st = calloc(1, sizeof(*st));
+  st->tableid = tableid;
+  st->extraid = extraid;
+  st2 = RB_INSERT_SORTED(&mt->mt_state, st, link, sect_cmp);
+  assert(st2 == NULL);
+  mt->mt_incomplete++;
+  mpegts_table_state_reset(mt, st, last);
   return st;
 }
 
diff --git a/src/input/mpegts/dvb_support.c b/src/input/mpegts/dvb_support.c
index fc11a2411..69ff0d875 100644
--- a/src/input/mpegts/dvb_support.c
+++ b/src/input/mpegts/dvb_support.c
@@ -1184,9 +1184,6 @@ void dvb_init( void )
 
 void dvb_done( void )
 {
-  extern SKEL_DECLARE(mpegts_psi_table_state_skel, mpegts_psi_table_state_t);
-
-  SKEL_FREE(mpegts_psi_table_state_skel);
 #if ENABLE_MPEGTS_DVB
   htsmsg_destroy(satellites);
 #endif