From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 13 Apr 2006 22:16:58 +0000 (+0000)
Subject: (RE_DUP_MAX): Update comment to match current implementation.
X-Git-Tag: v6.0~494
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3125c35bc714e4edf4649c49d367f8089ce9a0ad;p=thirdparty%2Fcoreutils.git

(RE_DUP_MAX): Update comment to match current implementation.
---

diff --git a/lib/regex.h b/lib/regex.h
index b1ae24906c..51857e5597 100644
--- a/lib/regex.h
+++ b/lib/regex.h
@@ -322,7 +322,14 @@ extern reg_syntax_t re_syntax_options;
 # ifdef RE_DUP_MAX
 #  undef RE_DUP_MAX
 # endif
-/* If sizeof(int) == 2, then ((1 << 15) - 1) overflows.  */
+
+/* RE_DUP_MAX is 2**15 - 1 because an earlier implementation stored
+   the counter as a 2-byte signed integer.  This is no longer true, so
+   RE_DUP_MAX could be increased to (INT_MAX / 10 - 1), or to
+   ((SIZE_MAX - 2) / 10 - 1) if _REGEX_LARGE_OFFSETS is defined.
+   However, there would be a huge performance problem if someone
+   actually used a pattern like a\{214748363\}, so RE_DUP_MAX retains
+   its historical value.  */
 # define RE_DUP_MAX (0x7fff)
 
 #endif /* defined __USE_GNU_REGEX */