From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 18 Dec 2012 00:04:21 +0000 (-0800)
Subject: aoe: fix use after free in aoedev_by_aoeaddr()
X-Git-Tag: v3.8-rc1~74^2~23
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=31279b1457f992f24eee8d45ddd647f5fce42cf6;p=thirdparty%2Fkernel%2Flinux.git

aoe: fix use after free in aoedev_by_aoeaddr()

We should return NULL on failure instead of returning a freed pointer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ed Cashin <ecashin@coraid.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index e66ccbf41a50b..98f2965778b9c 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -461,6 +461,7 @@ aoedev_by_aoeaddr(ulong maj, int min, int do_alloc)
 	d->targets = kcalloc(NTARGETS, sizeof(*d->targets), GFP_ATOMIC);
 	if (!d->targets) {
 		kfree(d);
+		d = NULL;
 		goto out;
 	}
 	d->ntargets = NTARGETS;