From: Tom de Vries Date: Mon, 29 Jul 2024 12:05:52 +0000 (+0200) Subject: [gdb/testsuite] Remove PR31554 kfail in gdb.threads/leader-exit-attach.exp X-Git-Tag: gdb-16-branchpoint~1296 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=312aea764b7b8ad621da601f4a88c859ccbcf12a;p=thirdparty%2Fbinutils-gdb.git [gdb/testsuite] Remove PR31554 kfail in gdb.threads/leader-exit-attach.exp When running test-case gdb.threads/leader-exit-attach.exp with target board native-extended-gdbserver I run into: ... (gdb) KFAIL: $exp: attach (PRMS: gdb/31555) print $_inferior_thread_count^M $1 = 0^M (gdb) KPASS: $exp: get valueof "$_inferior_thread_count" (PRMS server/31554) ... The PR mentioned in the KPASS, PR31554 was fixed by commit f1fc8dc2dcc ("Fix "attach" failure handling with GDBserver"), and consequently the PR is closed. Fix this by removing the corresponding kfail. Tested on x86_64-linux. --- diff --git a/gdb/testsuite/gdb.threads/leader-exit-attach.exp b/gdb/testsuite/gdb.threads/leader-exit-attach.exp index a1bc2d470d5..5334de2f881 100644 --- a/gdb/testsuite/gdb.threads/leader-exit-attach.exp +++ b/gdb/testsuite/gdb.threads/leader-exit-attach.exp @@ -59,14 +59,6 @@ gdb_test_multiple "attach $testpid" "attach" { } } -# With gdbserver, after we failed to attach, we hit PR server/31554: -# print $_inferior_thread_count -# Remote connection closed -# (gdb) KFAIL: gdb.threads/leader-exit-attach.exp: get valueof "$_inferior_thread_count" -if {!$attached && $is_gdbserver} { - setup_kfail "server/31554" "*-*-*" -} - set thread_count [get_valueof "" "\$_inferior_thread_count" -1] if {$thread_count == -1} {