From: Simon Marchi <simon.marchi@efficios.com>
Date: Wed, 31 Jul 2024 18:06:13 +0000 (-0400)
Subject: gdb, gdbserver, gdbsupport: remove -Wno-vla-cxx-extension
X-Git-Tag: gdb-16-branchpoint~1236
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3145bf08f2b2d95554d2b4dc35acc4f07249445c;p=thirdparty%2Fbinutils-gdb.git

gdb, gdbserver, gdbsupport: remove -Wno-vla-cxx-extension

Now that all known uses of VLAs within GDB are removed, remove the
`-Wno-vla-cxx-extension` (which was used to silence clang warnings) and
add `-Wvla`, such that any use of a VLA will trigger a warning.

Change-Id: I69a8d7f93f973743165b0ba46f9c2ea8adb89025
Reviewed-By: Keith Seitz <keiths@redhat.com>
---

diff --git a/gdb/configure b/gdb/configure
index 15ececfefa2..62deef2f341 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -31188,7 +31188,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wredundant-move \
 -Wmissing-declarations \
 -Wstrict-null-sentinel \
--Wno-vla-cxx-extension \
+-Wvla \
 "
 
 # The -Wmissing-prototypes flag will be accepted by GCC, but results
diff --git a/gdbserver/configure b/gdbserver/configure
index 3abc647acda..8d38b957e41 100755
--- a/gdbserver/configure
+++ b/gdbserver/configure
@@ -13715,7 +13715,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wredundant-move \
 -Wmissing-declarations \
 -Wstrict-null-sentinel \
--Wno-vla-cxx-extension \
+-Wvla \
 "
 
 # The -Wmissing-prototypes flag will be accepted by GCC, but results
diff --git a/gdbsupport/configure b/gdbsupport/configure
index 19b19c42c6f..54e32bbe2cd 100755
--- a/gdbsupport/configure
+++ b/gdbsupport/configure
@@ -14188,7 +14188,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wredundant-move \
 -Wmissing-declarations \
 -Wstrict-null-sentinel \
--Wno-vla-cxx-extension \
+-Wvla \
 "
 
 # The -Wmissing-prototypes flag will be accepted by GCC, but results
diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4
index d12bccbd3fb..2dadd7f99fd 100644
--- a/gdbsupport/warning.m4
+++ b/gdbsupport/warning.m4
@@ -52,7 +52,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wredundant-move \
 -Wmissing-declarations \
 -Wstrict-null-sentinel \
--Wno-vla-cxx-extension \
+-Wvla \
 "
 
 # The -Wmissing-prototypes flag will be accepted by GCC, but results