From: Tomas Mraz <tomas@openssl.org>
Date: Fri, 3 Nov 2023 07:57:21 +0000 (+0100)
Subject: tparam_on_enc_ext(): Remove dead code in cleanup
X-Git-Tag: openssl-3.3.0-alpha1~666
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=3150dbe7cb71de1ee7040c6fdeb254c88e775b7c;p=thirdparty%2Fopenssl.git

tparam_on_enc_ext(): Remove dead code in cleanup

Fixes Coverity 1548382

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22606)
---

diff --git a/test/quicapitest.c b/test/quicapitest.c
index 77c9598c698..41cf0fc7a87 100644
--- a/test/quicapitest.c
+++ b/test/quicapitest.c
@@ -1994,12 +1994,8 @@ static int tparam_on_enc_ext(QTEST_FAULT *qtf, QTEST_ENCRYPTED_EXTENSIONS *ee,
 
     rc = 1;
 err:
-    if (have_wpkt) {
-        if (rc)
-            WPACKET_finish(&wpkt);
-        else
-            WPACKET_cleanup(&wpkt);
-    }
+    if (have_wpkt)
+        WPACKET_cleanup(&wpkt);
     BUF_MEM_free(old_bufm);
     BUF_MEM_free(new_bufm);
     return rc;