From: Pauli <ppzgs1@gmail.com>
Date: Thu, 18 Mar 2021 00:31:33 +0000 (+1000)
Subject: test: fix coverity 1454040: resource leak
X-Git-Tag: openssl-3.0.0-alpha14~194
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=316c8dafd4504f595ab7de59d115ce2c46a4f27f;p=thirdparty%2Fopenssl.git

test: fix coverity 1454040: resource leak

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14596)
---

diff --git a/test/cmp_asn_test.c b/test/cmp_asn_test.c
index 33cc03cb4c1..c021ed03a69 100644
--- a/test/cmp_asn_test.c
+++ b/test/cmp_asn_test.c
@@ -42,12 +42,15 @@ static void tear_down(CMP_ASN_TEST_FIXTURE *fixture)
 
 static int execute_cmp_asn1_get_int_test(CMP_ASN_TEST_FIXTURE *fixture)
 {
+    int res;
     ASN1_INTEGER *asn1integer = ASN1_INTEGER_new();
-    ASN1_INTEGER_set(asn1integer, 77);
-    if (!TEST_int_eq(77, ossl_cmp_asn1_get_int(asn1integer)))
+
+    if (!TEST_ptr(asn1integer))
         return 0;
+    ASN1_INTEGER_set(asn1integer, 77);
+    res = TEST_int_eq(77, ossl_cmp_asn1_get_int(asn1integer));
     ASN1_INTEGER_free(asn1integer);
-    return 1;
+    return res;
 }
 
 static int test_cmp_asn1_get_int(void)