From: Phil Sutter <phil@nwl.cc>
Date: Fri, 16 May 2025 17:33:25 +0000 (+0200)
Subject: netlink: Keep going after set element parsing failures
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=31732dea34a2a4c484df13c4003728eca396e573;p=thirdparty%2Fnftables.git

netlink: Keep going after set element parsing failures

Print an error message and try to deserialize the remaining elements
instead of calling BUG().

Signed-off-by: Phil Sutter <phil@nwl.cc>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/netlink.c b/src/netlink.c
index 0154728b..bed816af 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -1452,7 +1452,9 @@ key_end:
 		key->byteorder = set->key->byteorder;
 		key->len = set->key->len;
 	} else {
-		BUG("Unexpected set element with no key\n");
+		netlink_io_error(ctx, NULL,
+			         "Unexpected set element with no key");
+		return 0;
 	}
 
 	expr = set_elem_expr_alloc(&netlink_location, key);