From: Krzysztof Kozlowski Date: Wed, 26 Aug 2020 14:48:57 +0000 (+0200) Subject: power: supply: ingenic: Simplify with dev_err_probe() X-Git-Tag: v5.10-rc1~72^2~65 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=31873dc23c3fa19b86fb543935f284ebbddf486e;p=thirdparty%2Fkernel%2Flinux.git power: supply: ingenic: Simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/supply/ingenic-battery.c b/drivers/power/supply/ingenic-battery.c index dd3d93dfe3eb0..32dc77fd9a952 100644 --- a/drivers/power/supply/ingenic-battery.c +++ b/drivers/power/supply/ingenic-battery.c @@ -147,11 +147,9 @@ static int ingenic_battery_probe(struct platform_device *pdev) psy_cfg.of_node = dev->of_node; bat->battery = devm_power_supply_register(dev, desc, &psy_cfg); - if (IS_ERR(bat->battery)) { - if (PTR_ERR(bat->battery) != -EPROBE_DEFER) - dev_err(dev, "Unable to register battery\n"); - return PTR_ERR(bat->battery); - } + if (IS_ERR(bat->battery)) + return dev_err_probe(dev, PTR_ERR(bat->battery), + "Unable to register battery\n"); ret = power_supply_get_battery_info(bat->battery, &bat->info); if (ret) {