From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 10 Oct 2024 21:22:27 +0000 (-0700)
Subject: Merge branch 'ps/leakfixes-part-8'
X-Git-Tag: v2.48.0-rc0~126
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=31bc4454de66c22bc8570fd3af52a99843ac69b0;p=thirdparty%2Fgit.git

Merge branch 'ps/leakfixes-part-8'

More leakfixes.

* ps/leakfixes-part-8: (23 commits)
  builtin/send-pack: fix leaking list of push options
  remote: fix leaking push reports
  t/helper: fix leaks in proc-receive helper
  pack-write: fix return parameter of `write_rev_file_order()`
  revision: fix leaking saved parents
  revision: fix memory leaks when rewriting parents
  midx-write: fix leaking buffer
  pack-bitmap-write: fix leaking OID array
  pseudo-merge: fix leaking strmap keys
  pseudo-merge: fix various memory leaks
  line-log: fix several memory leaks
  diff: improve lifecycle management of diff queues
  builtin/revert: fix leaking `gpg_sign` and `strategy` config
  t/helper: fix leaking repository in partial-clone helper
  builtin/clone: fix leaking repo state when cloning with bundle URIs
  builtin/pack-redundant: fix various memory leaks
  builtin/stash: fix leaking `pathspec_from_file`
  submodule: fix leaking submodule entry list
  wt-status: fix leaking buffer with sparse directories
  shell: fix leaking strings
  ...
---

31bc4454de66c22bc8570fd3af52a99843ac69b0
diff --cc scalar.c
index 73b79a5d4c,ede616ad4f..ac0cb579d3
--- a/scalar.c
+++ b/scalar.c
@@@ -732,10 -732,8 +732,11 @@@ static int cmd_reconfigure(int argc, co
  			succeeded = 1;
  
  		the_repository = old_repo;
+ 		repo_clear(&r);
  
 +		if (toggle_maintenance(1) >= 0)
 +			succeeded = 1;
 +
  loop_end:
  		if (!succeeded) {
  			res = -1;