From: William Lallemand <wlallemand@haproxy.com>
Date: Wed, 2 Apr 2025 08:02:07 +0000 (+0200)
Subject: BUILD: ssl/ckch: potential null pointer dereference
X-Git-Tag: v3.2-dev9~23
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=31bd3627cd627536c749576a357ba0bf8a73b9d1;p=thirdparty%2Fhaproxy.git

BUILD: ssl/ckch: potential null pointer dereference

src/ssl_ckch.c: In function ‘ckch_conf_parse’:
src/ssl_ckch.c:4852:40: error: potential null pointer dereference [-Werror=null-dereference]
 4852 |                                 while (*r) {
      |                                        ^~

Add a test on r before using *r.

No backport needed
---

diff --git a/src/ssl_ckch.c b/src/ssl_ckch.c
index 4352bfc26..203d25270 100644
--- a/src/ssl_ckch.c
+++ b/src/ssl_ckch.c
@@ -4849,7 +4849,7 @@ int ckch_conf_parse(char **args, int cur_arg, struct ckch_conf *f, int *found, c
 
 				goto out;
 array_err:
-				while (*r) {
+				while (r && *r) {
 					char *prev = *r;
 					r++;
 					free(prev);