From: Andrey Volk <andywolk@gmail.com>
Date: Thu, 1 Apr 2021 13:25:10 +0000 (+0300)
Subject: [mod_kazoo] scan-build: Argument with 'nonnull' attribute passed null in kz_endpoint_... 
X-Git-Tag: v1.10.7^2~257
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=31c10fac222f070f288dfa91cd4a7517396fa5f0;p=thirdparty%2Ffreeswitch.git

[mod_kazoo] scan-build: Argument with 'nonnull' attribute passed null in kz_endpoint_outgoing_channel()
---

diff --git a/src/mod/event_handlers/mod_kazoo/kazoo_endpoints.c b/src/mod/event_handlers/mod_kazoo/kazoo_endpoints.c
index cb2b28cb26..4ddfeddae4 100644
--- a/src/mod/event_handlers/mod_kazoo/kazoo_endpoints.c
+++ b/src/mod/event_handlers/mod_kazoo/kazoo_endpoints.c
@@ -222,20 +222,20 @@ static switch_call_cause_t kz_endpoint_outgoing_channel(switch_core_session_t *s
 		}
 
 		if (!call_fwd_is_valid) {
-			dest = strdup(endpoint_dial);
+			dest = endpoint_dial ? strdup(endpoint_dial) : strdup("");
 		} else if (call_fwd_is_failover) {
 			switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "setting failover => %s\n", callforward_dial);
-			dest = strdup(endpoint_dial);
+			dest = endpoint_dial ? strdup(endpoint_dial) : strdup("");
 			failover_dial = callforward_dial;
 		} else if (call_fwd_is_substitute) {
-			switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "setting call fwd substitute => %s\n", callforward_dial);
-			dest = strdup(callforward_dial);
+			dest = callforward_dial ? strdup(callforward_dial) : strdup("");
+			switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "setting call fwd substitute => %s\n", dest);
 		} else {
 			dest = switch_mprintf("%s%s%s", endpoint_dial ? endpoint_dial : "", (endpoint_dial ? endpoint_separator ? endpoint_separator : "," : ""), callforward_dial);
 			switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "setting call fwd append => %s => %s\n", callforward_dial, dest);
 		}
 	} else {
-		dest = strdup(endpoint_dial);
+		dest = endpoint_dial ? strdup(endpoint_dial) : strdup("");
 	}
 
 	dialed_user = (char *)switch_xml_attr(x_user, "id");