From: Ævar Arnfjörð Bjarmason Date: Tue, 7 Jun 2022 15:50:04 +0000 (+0200) Subject: remote.c: don't dereference NULL in freeing loop X-Git-Tag: v2.37.0-rc0~3^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=323822c72be59ce2900cc036c5bad4f10bafbb53;p=thirdparty%2Fgit.git remote.c: don't dereference NULL in freeing loop Fix a bug in fd3cb0501e1 (remote: move static variables into per-repository struct, 2021-11-17) where we'd free(remote->pushurl[i]) after having NULL'd out remote->pushurl. itself. We free "remote->pushurl" in the next "for"-loop, so doing this appears to have been a copy/paste error. Before this change GCC 12's -fanalyzer would correctly note that we'd dereference NULL in this case, this change fixes that: remote.c: In function ‘remote_clear’: remote.c:153:17: error: dereference of NULL ‘*remote.pushurl’ [CWE-476] [-Werror=analyzer-null-dereference] 153 | free((char *)remote->pushurl[i]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [...] Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano --- diff --git a/remote.c b/remote.c index eb07b667db..bb55038e4c 100644 --- a/remote.c +++ b/remote.c @@ -146,7 +146,7 @@ static void remote_clear(struct remote *remote) for (i = 0; i < remote->url_nr; i++) free((char *)remote->url[i]); - FREE_AND_NULL(remote->pushurl); + FREE_AND_NULL(remote->url); for (i = 0; i < remote->pushurl_nr; i++) free((char *)remote->pushurl[i]);