From: Manivannan Sadhasivam Date: Thu, 14 Dec 2023 06:33:28 +0000 (+0530) Subject: PCI: epf-mhi: Fix the DMA data direction of dma_unmap_single() X-Git-Tag: v6.8-rc1~62^2~55^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=327ec5f70609cf00c6f961073c01857555c6a8eb;p=thirdparty%2Fkernel%2Flinux.git PCI: epf-mhi: Fix the DMA data direction of dma_unmap_single() In the error path of pci_epf_mhi_edma_write() function, the DMA data direction passed (DMA_FROM_DEVICE) doesn't match the actual direction used for the data transfer. Fix it by passing the correct one (DMA_TO_DEVICE). Fixes: 7b99aaaddabb ("PCI: epf-mhi: Add eDMA support") Reviewed-by: Krzysztof Wilczyński Link: https://lore.kernel.org/r/20231214063328.40657-1-manivannan.sadhasivam@linaro.org Signed-off-by: Manivannan Sadhasivam --- diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c index 472bc489b754b..d3d6a1054036b 100644 --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c @@ -424,7 +424,7 @@ static int pci_epf_mhi_edma_write(struct mhi_ep_cntrl *mhi_cntrl, } err_unmap: - dma_unmap_single(dma_dev, src_addr, buf_info->size, DMA_FROM_DEVICE); + dma_unmap_single(dma_dev, src_addr, buf_info->size, DMA_TO_DEVICE); err_unlock: mutex_unlock(&epf_mhi->lock);